max skew time + batch submission time calculation refactor #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omritoptix
reviewed
Dec 17, 2024
| @@ -314,11 +311,36 @@ func (m *Manager) UpdateLastSubmittedHeight(event pubsub.Message) { | |||
| } | |||
| } | |||
|
|
|||
| func (m *Manager) GetLastBlockInSettlementTime() (time.Time, error) { | |||
| lastBlockInSettlement, err := m.Store.LoadBlock(m.LastSettlementHeight.Load()) | |||
There was a problem hiding this comment.
I think the LastSettlementHeight may get pruned no?
pruningHeight = min(m.NextHeightToSubmit(), uint64(retainHeight))if that's the case and we fallback to first block it may cause unnecessary halt.
There was a problem hiding this comment.
true. good catch. i keep last submitted block without pruning to enable skew time calculation and keep code simplicity.
srene
force-pushed
the
srene/1282-max-skew-time-fix
branch
from
f9a7024 to
82abf78
Compare
srene
changed the title
omritoptix
previously approved these changes
Dec 19, 2024
block/submit.go
Outdated
|
|
||
| // isLastBatchRecent returns true if the last batch submitted is more recent than submitBatchTime | ||
| // in case of no submission time the first block produced is used as a reference. | ||
| func (m *Manager) isLastBatchRecent(submitBatchTime time.Duration) bool { |
There was a problem hiding this comment.
submitBatchTime -> maxBatchSubmitTime
if we don't keep this names clear it becomes really really complicated understanding what each function does.
omritoptix
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Standards
This PR solves two issues:
Close #1282 ,#1287
<-- Briefly describe the content of this pull request -->
For Author:
godoccommentsFor Reviewer:
After reviewer approval: